[v1.5][F14-B2] Medeina #69
Conversation
There was a problem hiding this comment.
@Aquarinte @Robert-Peng @wynonaK @chialejing
Good job on the PR! Just some minor comments. Also, remember to update your README, User Guide and Developer Guide to reflect your product name and the respective product descriptions as well.
Do leave this PR open as we will be tracking the milestones through this.
README.adoc
Outdated
| @@ -1,9 +1,8 @@ | |||
| = Address Book (Level 4) | |||
There was a problem hiding this comment.
Do remember to update this to your product name!
README.adoc
Outdated
| https://ci.appveyor.com/project/damithc/addressbook-level4[image:https://ci.appveyor.com/api/projects/status/3boko2x2vr5cc3w2?svg=true[Build status]] | ||
| https://coveralls.io/github/se-edu/addressbook-level4?branch=master[image:https://coveralls.io/repos/github/se-edu/addressbook-level4/badge.svg?branch=master[Coverage Status]] | ||
| https://travis-ci.org/CS2103JAN2018-F14-B2/main[image:https://travis-ci.org/CS2103JAN2018-F14-B2/main.svg?branch=master[Build Status]] | ||
| https://coveralls.io/github/se-edu/CS2103JAN2018-F14-B2/main?branch=master[image:https://coveralls.io/repos/github/CS2103JAN2018-F14-B2/main/badge.svg?branch=master[Coverage Status]] |
There was a problem hiding this comment.
Good job on updating Travis and Coveralls to point to your repo!
|
|
||
| |`* *` |user |manage the "rooms" in hospital |make space for newly hospitalized pet patient | ||
|
|
||
| |`*` |user with many pet patients in the address book |sort pet patients by name |locate a pet patient easily |
There was a problem hiding this comment.
Good job on coming up with a variety of user stories! It does seem like they match the needs of your target user profile. However, you may want to be more specific on the type of user involved for each user story. Do update the user in the user stories to reflect your target user profile, which in your case are vet/vet assistants.
|
|
||
| *Value proposition*: manage contacts faster than a typical mouse/GUI driven app | ||
| *Value proposition*: all-in-one vet assistant app that can view and make appointments and search for information |
There was a problem hiding this comment.
Well done on defining a clear and specific target user profile.
There was a problem hiding this comment.
@Aquarinte @Robert-Peng @wynonaK @chialejing
Good job on updating the About Us, README and User Guide. Do keep the PR open after reading my remarks.
Ideally, you should think through the product's end behavior and write the entire UG, for all the commands which you would want to implement. Then mark the features as future (v2.0) which you do not intend to implement in the project duration, which I see you guys have done. Good job on that!
Finally, do ensure you update your issue tracker to reflect the user stories and tasks that you want to implement/complete during the duration of this project. You may refer to nus-cs2103-AY1718S2/forum#28 and https://github.com/MyTAOrg/DemoGradle/issues to see how you can go about doing it. I will talk more about it during tutorial as well.
Implement full parsing logic for Add command
There was a problem hiding this comment.
@Aquarinte @Robert-Peng @wynonaK @chialejing
Good job on updating the DG to reflect your implementations as well as updating your issue tracker to reflect the different story types and tasks! It also looks like you guys are on track to complete your product! However, do remember to supplement your implementation description with diagrams like sequence or class diagrams.
Otherwise, keep up the good work!
Implement size restriction for autocomplete suggestion list and some minor fixes/improvements
Pull from team repo
…for options and prefixes
Disable Calendar buttons & Add Exception
Implement descriptions for options and prefixes in autocomplete drop down menu
Interval fixed to 30
Fix + Added JUnit Test for EditCommand
Updated DG and Diagrams
Minor updates on docs
Update Docs
Update DG and UG, as well as fixed error for date parser.
@chialejing @wynonaK @Robert-Peng